Remove direct read from TLS underlying conn #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofekshenawa @vladvildanov sorry for the direct ping, would anyone of you be able to have a look at this please? |
|
@rentziass Hey! Thanks for reaching us out! Just for the context, currently it reads from TLS underlying socket, so it means that it reads unencrypted data? |
|
@vladvildanov 👋 it's all in the issue but the tldr is that reading from |
vladvildanov
approved these changes
Oct 7, 2024
rentziass
added a commit
to rentziass/go-redis
that referenced
this pull request
Oct 7, 2024
Merged
vladvildanov
pushed a commit
that referenced
this pull request
Oct 9, 2024
vladvildanov
pushed a commit
to vladvildanov/go-redis
that referenced
this pull request
Oct 14, 2024
vladvildanov
added a commit
that referenced
this pull request
Oct 14, 2024
Co-authored-by: Francesco Renzi <[email protected]>
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3137.
This essentially reverts 0858ed2, to avoid corrupting TLS sessions by directly reading from the underlying
net.Conn. This is blocking upgrades to> 9.5.2if using TLS.conn_check.gois quite different on the v9.6 branch (it changed here), should I open another PR to fix that as well?